9 comments

Add a comment…

Sign in

prestine

Your email address

Check!

invalid email

(thinking…)

Reset

or sign in with

• 
• 

UserVoice password

Forgot password?

Create a password

Your name

I agree to the terms of service

You'll receive a confirmation email with a link to create a password (optional).

Signed in as (Sign out)

Close

Close

Post comment Submitting...

• Tony Hardie commented  ·  Mar 29, 2010 3:40 pm  ·  Flag as inappropriate  ·  Delete

  actually it seems you already do this but you only add the job text to the review and not the JOB ID itself, seems like a pretty simple change.

• Admingsporar (Admin, Code Collaborator) commented  ·  Oct 22, 2009 6:17 pm  ·  Flag as inappropriate  ·  Delete

  Okay, now, back to Richard Hyde's request.

  I hate to sound dumb (well, actually, I don't mind it that much :-) ), but I'm still pretty in the dark with exactly what is envisioned here. Let's take this piece by piece:

  1. "when submitting perforce changelists the user can be prompted to enter job information."

  Just to be clear: when submitting Perforce changelists to the Perforce depot, right? And what specific job information are you referring to?

  2. "In this list I would see items from my defect tracker and ideally open smarbear reviews."

  In which list? And how does the list get populated?

  3. "If II select a smartbear review (or maybe even a smartbear defect) a perfroce trigger would then upload the diffs into smartbear automatically."

  This sort of suggests to me that the review already exists, but has no changelists attached to it, is that right?

• Admingsporar (Admin, Code Collaborator) commented  ·  Oct 22, 2009 6:04 pm  ·  Flag as inappropriate  ·  Delete

  Hello all -

  Thanks for the responses. Just to be clear: what Tony Hardie wants is actually described in a separate entry: http://feedback.codecollab.com/pages/4652-code-collaborator-features/suggestions/86189-perforce-jobs-integration?ref=title

  So in Tony's case, he does not want (or need) for Code Collaborator to create a Perforce job (which is what this entry is all about). Quite the opposite, as described in that other entry, he just wants Code Collaborator to pull information from an existing Perforce job. I'll eventually add more details/questions over in that other entry.

• Tony Hardie commented  ·  Oct 22, 2009 10:17 am  ·  Flag as inappropriate  ·  Delete

  since we already have jira and jobs sync all we need is for the code review to show the job ID that we use to link to the jira defect. (since we name our jobs the same as the jira ID)

• richardhyde commented  ·  Oct 21, 2009 4:41 pm  ·  Flag as inappropriate  ·  Delete

  @gsporar

  #1, yes, create a job at the same time as review creation
  #2, I'd say on enabling this feature, any open review would be created as a job.

  Yes, when submitting perforce changelists the user can be prompted to enter job information. In this list I would see items from my defect tracker and ideally open smarbear reviews. If II select a smartbear review (or maybe even a smartbear defect) a perfroce trigger would then upload the diffs into smartbear automatically.

  Yes, this would be a one to one mapping between p4 jobs and smartbear reviews. You may, however, select as many p4 jobs as you want per changelist... associating it with as many standard jobs, defects, reviews, etc as you like.

• Admingsporar (Admin, Code Collaborator) commented  ·  Oct 17, 2009 4:54 pm  ·  Flag as inappropriate  ·  Delete

  I'm a bit unclear on exactly what the desired workflow is here.

  The original post says: "create P4 jobs for every review in the system" which raises some questions:

  1. *When* should the p4 job be created? At the same time that the review is created?

  2. For existing reviews, would it be necessary to offer an option to create a p4 job for each of those existing reviews?

  Also, on this: "so when we submit changelists we can natively select which review it may be associated with" What does "submit changelists" mean? Submit the changelist to the Perforce depot? Or attach a changelist to a new (or existing) code review?

  Also, does this assume a one-to-one mapping between p4 jobs and code reviews?

• patrickb commented  ·  Jun 17, 2009 2:12 pm  ·  Flag as inappropriate  ·  Delete

  Yeah, I think Perforce jobs should stay associated with issue tracking, not with code collaborator. If this is done, make sure its an option!

• Tim Kaddoura commented  ·  Apr 17, 2009 9:36 am  ·  Flag as inappropriate  ·  Delete

  This should be an easy-peasy-lemon-squeezy implementation, but pays huge integration dividends!!

• Tony Hardie commented  ·  Apr 16, 2009 4:14 pm  ·  Flag as inappropriate  ·  Delete

  we already have jira create a perforece job for us, we just want the code review system to show the p4 job and a way to provide url that links that ID to the defect system