Reviews should stay in 'Fix Defects' until author is done.
Right now a review will get kicked out of the 'Fix Defects' phase (back to 'Inspection') if the author makes any comment on a review. This really seems like a bug in the state flow for a review. Why doesn't it stay in this state until the Author click the 'Defects Fixed; Proceed to Verification' button at the bottom of the review summary? We'd really like authors to be able to comment on defects when they fix them and after they are done forward the review back to the reviewers to re-inspect/verify. Right now my reviewers complain that they "waste" a lot of time looking at reviews before the author is done/ready for them to. Can we at least have the option of enabling a more rigid state flow with clearly defined ownership for each state, i.e. Reviewers own Inspection, Author own Fix Defects, etc.
tcowan
shared this idea
7 comments
-
P. Pecina
commented
This seems like a good idea to improve the review process flow and correct phase of review.
-
Tom Kirby-Green
commented
Would love to see this fixed as a holding measure while you fix the underlying feature gap: lack of customizable review workflows.
-
Sam Holloway
commented
Yes yes yes! Very keen to see this.
-
B Spencer
commented
Great idea!!! The less back & forth the better.
-
Woody
commented
Totally agree. The review should stay in "Revork" state until the "Defects Fixed; Proceed to Verification" button is pressed.
My team thinks that this is extremely annoying and it costs us a lot of extra time.
Please fix!!
-
Saman
commented
I do agree with "tcowan", review should be kept in "Fixed Defects" phase until author clicks on "Defects Fixed; Proceed to Verification" button. Current behavior definitely leads to a confusion.
-
Jim Taylor
commented
The issue is that the author never has a chance to annotate "fixed code". The author has two choices; annotate/provide comments before new code is uploaded or after new code is uploaded. Both choices don't provide desired behavior.
Applying the annotations before the code is uploaded results in two bad behaviors:
1) Reviewers are notified of the comment and yet they are looking at the old code. Any comments regarding the new code can't be understood in the context of the new code because it hasn't been uploaded yet.
2) The annotations apply to incorrect lines because the new code hasn't been uploaded yet.Applying annotations after the code has been uploaded is too late because all reviewers are notified that new code has been uploaded and it is now time to resume inspection. Now there is a thrashing between code being in review state and the author coming in and providing additional comments, which causes reviewers to have to go back and look at the new comments.
Solution:
As when a new review is created and the author is allowed to upload code and annotate before notifying reviewers, Rework should be treated exactly the same. The author should be able to upload new code and then annotate and finally transition the code back to the reviewers.Please do this....
