Perforce create-review trigger
The create-review trigger is handy, but it only works for Subversion. Support for this in other version control systems is desired -- especially Perforce.
AdminBrandon DuRette
(Admin, Code Collaborator)
shared this idea
3 comments
-
Andreas Pfister
commented
Thank you for the comment, that helped. Are you implying that the create-review trigger can be also used with perforce as it is independent of the SCM?
-
You don't actually need a separate proper trigger, you can use the regular command line tool "ccollab addchangelist new %change%" with a few p4 and collab options to just create a review upon completion.
You'll hit some problems with rework if you do this however - since each change is going to its very own review there isn't an straightforward way to indicate that a particular change is actually a rework for review X.
The distinction between ccollab addchangelist is that the create-review trigger behaves exactly as documented, and for some reason nobody actually reads that docco correctly. The create-review trigger looks at the changelist comment and if it claims to be already reviewed it doesn't create an additional review.
-
Andreas Pfister
commented
As i understand this, exactly this feature is mentioned here:
http://support.smartbear.com/articles/codecollaborator/components/"We also supply a special tool for use as a Perforce server trigger. For example, you can use this to enforce a rule like "Every submit on this branch requires a review." You can also use this to automatically upload all submitted changelists into CodeCollaborator so that you can review code after it has been checked in. This can be especially useful with off-shore development groups."
can i do this already?
