9 comments

Add a comment…

Sign in

prestine

Your email address

Check!

invalid email

(thinking…)

Reset

or sign in with

• 
• 

UserVoice password

Forgot password?

Create a password

Your name

I agree to the terms of service

You'll receive a confirmation email with a link to create a password (optional).

Signed in as (Sign out)

Close

Close

Post comment Submitting...

• Ezeckiel commented  ·  April 12, 2010 12:53  ·  Flag as inappropriate  ·  Delete

  This look like a way to accept comments with reading them... which is a really bad review practice.

• bds14 commented  ·  January 15, 2010 11:50  ·  Flag as inappropriate  ·  Delete

  The "Unless activity by author occurs, I am finished." button fulfills my need.

• AdminCody Casterline (Admin, Code Collaborator) commented  ·  January 14, 2010 15:27  ·  Flag as inappropriate  ·  Delete

  In v5.0 a user can select "Unless activity by author occurs, I am finished.", which means that comments made by other reviewers/observers do not bring you back to a review. Has this fixed the issue? If not, please comment and let us know!

• Adminjasoncohen (Admin, Code Collaborator) commented  ·  October 28, 2008 11:50  ·  Flag as inappropriate  ·  Delete

  Agreed on the "further discussion." Although Roy is right, that's an all-or-nothing, not per-review or per-conversation.

  In v5.0 we're planning to let you say "I'm done with this review, don't invite me back." Will work on a per-review basis. But this suggests a per-conversation basis, so we should keep talking about that idea.

• AdminRoy (Admin, Code Collaborator) commented  ·  October 28, 2008 07:07  ·  Flag as inappropriate  ·  Delete

  Note Code Collaborator already has a "Works independently of other participants" Role configuration that does pretty much what bds14 is asking for... See http://www.smartbear.com/docs/collab-manual/index.html?admin_roles.html

• bds14 commented  ·  October 27, 2008 10:42  ·  Flag as inappropriate  ·  Delete

  I think part of the real solution is to have a way to opt-out of further discussion. If I've reviewed the files, and a couple days later another reviewer starts reviewing the code... well, I'm done already and don't need to be invited back again.

  Right now, the workaround is to ask the admin to change you to an observer so you don't have to keep on reading comments.

• Adminpjz (Admin, Code Collaborator) commented  ·  October 22, 2008 06:05  ·  Flag as inappropriate  ·  Delete

  1) Having to ignore comments is a design deficiency. We should figure out how to make those comments be auto-ignored. Perhaps settings to "auto-mark-read" some comment types, like the "Defect marked fixed" and "New file uploaded" and etc? With default settings that mimic the current behavior?

  2) Or the above 'Finish this regardless' could mark-all-read as well, as part of its functionality.

• AdminBrandon DuRette (Admin, Code Collaborator) commented  ·  October 21, 2008 11:09  ·  Flag as inappropriate  ·  Delete

  It's more than that, if the review comes back into review phase, the comments are still marked read. For instance, if I can quickly see that all the comments are just "Defect marked fixed" comments from other reviewers, I can mark them read. Then if someone makes a "real" comment, I don't have to sift through the ones I previously chose to ignore and ignore them again.

• Adminpjz (Admin, Code Collaborator) commented  ·  October 21, 2008 06:50  ·  Flag as inappropriate  ·  Delete

  What's the real purpose here? If it's to be able to finish the review, wouldn't a "Finish this regardless of outstanding comments" button be a more accurate action to offer?