Allow chat comments to be edited and deleted by their author
I find that I want to edit typos in comments and remove them as I learn review. It is really annoying that the comments can't be changed.
anonymous
shared this idea
In 6.0 you can “redact” comments. Redacted comments don’t have to be “marked read” and are faded in the UI.
I’m marking this suggestion as “completed” – if you have more specific suggestions please open new ones.
11 comments
-
chris.nelson
commented
Redacting really doesn't address the original intent of this request at all. For example, if a noob (like me!) goes through and enters a lot of redundant or useless comments and I want to improve the s/n ratio, having grey blobs doesn't really clean up the visual noise. I want to be able to remove the comment so it appears to have never existed, has no trace left on the screen, etc.
-
Srikanth
commented
I think just allowing edit/delete of comment is sufficient. History of edit of defect is already available currently and that is fine. When it comes to comment, we are just trying to share a chat with our colleagues for which history is probably not important.
-
ruza
commented
I would like to be able to move line references. I had a big problem with this during review of a word document. One colleague used references to actual lines of a document other used reference to pages of the document. Once the line numbers are entered they can't be changed.
-
Jason Kottler
commented
I think that comments need to be editable / removable during the "annotation" stage of a review at least. That way, before the review has begun, the author can can make whatever changes are necessary. It would also be fine if they could be changed / deleted anytime before a reply is posted to one. And sure, record the change history for audits / whatever.
-
Linda O'Meara
commented
Agree that there should be a way to go back and edit them, and that the editing/deletion should be visually obvious (like J. Smith <deleted>) with a link to a detailed audit log of what was changed/deleted.
-
Linda O'Meara
commented
Agree that there should be a way to go back and edit them, and that the editing/deletion should be visually obvious (like J. Smith <deleted>) with a link to a detailed audit log of what was changed/deleted.
-
Mattias Andersson
commented
I love Ron Brown's idea of having a comment/defect transaction that can be committed, all at once. Not only will this fix the annoyance of not being able to fix typos, it also adds support for some currently-unsupported workflows (like Ron described).
-
Ron Brown
commented
I also prefer to work on comments as a set prior to posting, because I often find that I learn as I work through a review session, and that comments I wrote out an hour ago might benefit from modification. This isn't a court of law, it's a tool for helping developers to help each other. Perhaps a compromise approach -- permit a reviewer to "pend" a new comment during a review, and to then post all "pend"ed comments using a link from the main review page. In this way, a reviewer could spend an hour reading the code, taking private notes in-context, perhaps extending, clarifying, or deleting comments from that session, then at the end, when satisfied with the list, could post the set with a single action. A popup to review the "pend" list would be useful as well. Once posted, they become public and unalterable just as now. A reviewer could then go back and accumulate some more.
We're trying out this product to replace a more manual review method, but that manual review method does have one signicant benefit in that a reviewer can completely compose their thoughts prior to posting any of them. To accomplish that using this tool, one would have to record them all offline in some other editor, then transfer them in, pretty much defeating all the advantages of commenting right from a code browser.
-
AdminRoy
(Admin, Code Collaborator)
commented
btoombs - you CAN edit the custom fields of a defect. Just click "edit"
-
btoombs
commented
Similarly, I'd like to be able to edit the custom fields of a defect after it's entered. Here's my use case: I use a value of 'Question' on a custom defect field named Severity. This allows people to flag a possible defect. If it turns out not to be a defect, it is deleted. If it turns out to be a real defect, it stays, but it I'd like change the value from Question to a real value.
-
ruza
commented
There is a valid counter point, there should be reliable history of discussion. Participants should not have option to deny or alter what they said. Yes, I would like to fix typos in my comments/defects, but then there would have to be another view showing the whole, true history of the discussion.
