6 comments

Add a comment…

Sign in

prestine

Your email address

Check!

invalid email

(thinking…)

Reset

or sign in with

• 
• 

UserVoice password

Forgot password?

Create a password

Your name

I agree to the terms of service

You'll receive a confirmation email with a link to create a password (optional).

Signed in as (Sign out)

Close

Close

Post comment Submitting...

• Ian T. Johns commented  ·  April 20, 2011 13:17  ·  Flag as inappropriate  ·  Delete

  By default or option, a previously-'Accept'd (or -'Read') item should NOT need to be re-'Accept'd UNLESS the code for the item changes OR a new comment/bug is added to the item.

  Combined with http://feedback.codecollab.com/forums/4652-code-collaborator-features/suggestions/77293-hide-or-fold-accepted-chat-sessions?ref=title, non-touched items could be collapsed by default -- making subsequent reviews easier to detect which remaining items only still need review.

• Francois Breton-Jacques commented  ·  April 20, 2011 10:03  ·  Flag as inappropriate  ·  Delete

  If we put aside "diff", I would still want badly an option to keep accepted items accepted. When a new revision is uploaded, the accepted comments / solved defects often stay the same, and I will certainly work on totally new items, added after looking at the diff from the two last version.

  I think it would be fairly simple (and really effective for us) to have a global option (keep objects accepted when a new revision is uploaded) to choose this behavior.

  Of course, if the last "diff" could identify some changes and mark the appropriates items unaccepted, it would be even better.

• Mattias J commented  ·  December 15, 2010 06:53  ·  Flag as inappropriate  ·  Delete

  This is making it increasingly hard to work with Code Collaborator

• AdminRoy (Admin, Code Collaborator) commented  ·  December 01, 2008 07:00  ·  Flag as inappropriate  ·  Delete

  You have to realize that diff isn't a perfect science. Often there is no strict "correct" answer. The best way to diff can be subjective.

• Mattias J commented  ·  November 26, 2008 00:02  ·  Flag as inappropriate  ·  Delete

  "Oh, ye of little faith"...

  Seriously, if there is something wrong with the diff algorithm the Diff view is apparently incorrect, which is much more of a problem.

  Even apart from that, it probably costs us way, way more time to go over the same comments again and again, than what would be the effect of missing a no-longer accepted comment once in a while.

• AdminRoy (Admin, Code Collaborator) commented  ·  November 24, 2008 07:12  ·  Flag as inappropriate  ·  Delete

  This would require a lot of faith in our diff algorithm...